Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lemurs: init at 0.3.1 #246287

Merged
merged 2 commits into from
Aug 2, 2023
Merged

lemurs: init at 0.3.1 #246287

merged 2 commits into from
Aug 2, 2023

Conversation

JeremiahSecrist
Copy link
Contributor

Description of changes

Adds lemurs, a tty based display manager. I have tested it runs and accepts inputs.
This resolves #246035

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !

Thanks for your contribution.

I've left some comments, left me know if this is clear enough.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/display-managers/lemurs/default.nix Outdated Show resolved Hide resolved
owner = "coastalwhite";
repo = pname;
rev = "v${version}";
sha256 = "sha256-6mNSLEWafw8yDGnemOhEiK8FTrBC+6+PuhlbOXTGmN0=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hash in place of sha256.

This is optional since it could be automatized treewide at some point.

The idea is to avoid using sha256 as attribute and use hash everywhere.

Since there could be different hashing algorithms in use, this make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixed.

pkgs/applications/display-managers/lemurs/default.nix Outdated Show resolved Hide resolved
pkgs/applications/display-managers/lemurs/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks !

Please squash your commits so that this PR contains only 2 commits.

  • 1 commit for adding you as maintainer
  • 1 commit for the rest

@JeremiahSecrist
Copy link
Contributor Author

This should fix all aforementioned issues. Thanks for being patient!

owner = "coastalwhite";
repo = pname;
rev = "v${version}";
sha256 = "sha256-6mNSLEWafw8yDGnemOhEiK8FTrBC+6+PuhlbOXTGmN0=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixed.

applied editorconfig settings

fix: lf line ending issue

fix: repo can not be pname due to bind issues

fix: use cargoHash not cargoSha256

lint: build inputs should new line

lint: callPackage should have space in attrset
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@drupol drupol merged commit 1b77a22 into NixOS:master Aug 2, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: lemurs
3 participants